Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 451893003: Adding the VerifyModule function (and helpers) to safe browsing. (Closed)

Created:
6 years, 4 months ago by krstnmnlsn
Modified:
6 years, 4 months ago
Reviewers:
csharp
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Recommitting: https://codereview.chromium.org/406043003/ (originally reverted because the buildbots weren't pointed to verifier_test_dll.dll by unit_tests.isolate) ========================================================= Adding the VerifyModule function (and helpers) to safe browsing. This function allows us to compare a module in memory with its original on disk, and identify any differences (after accounting for relocations). The state of the module (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is returned along with a list of the possibly modified exported functions of the module. BUG=401854 TBR= noelutz@google.com, robertshield@chromium.org, csharp@chromium.org, asvitkine@chromium.org, grt@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288417

Patch Set 1 : original from 406043003 #

Patch Set 2 : Adding verifier_test_dll.dll to unit_tests.isolate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -22 lines) Patch
A chrome/browser/safe_browsing/module_integrity_verifier_win.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/module_integrity_verifier_win.cc View 1 chunk +298 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc View 1 1 chunk +160 lines, -0 lines 0 comments Download
A + chrome/browser/safe_browsing/verifier_test/verifier_test_dll.cc View 1 chunk +15 lines, -14 lines 0 comments Download
A + chrome/browser/safe_browsing/verifier_test/verifier_test_dll.def View 1 chunk +8 lines, -8 lines 0 comments Download
A chrome/browser/safe_browsing/verifier_test/verifier_unittest.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
krstnmnlsn
The CQ bit was checked by krstnmnlsn@chromium.org
6 years, 4 months ago (2014-08-08 19:25:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krstnmnlsn@chromium.org/451893003/20001
6 years, 4 months ago (2014-08-08 19:27:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 19:27:30 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-08 19:27:31 UTC) #4
csharp
lgtm
6 years, 4 months ago (2014-08-08 19:29:59 UTC) #5
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 4 months ago (2014-08-08 19:30:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krstnmnlsn@chromium.org/451893003/20001
6 years, 4 months ago (2014-08-08 19:31:48 UTC) #7
csharp
The CQ bit was unchecked by csharp@chromium.org
6 years, 4 months ago (2014-08-08 19:33:19 UTC) #8
csharp
On 2014/08/08 19:33:19, csharp wrote: > The CQ bit was unchecked by mailto:csharp@chromium.org Setting NOTRY=true ...
6 years, 4 months ago (2014-08-08 19:34:15 UTC) #9
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 4 months ago (2014-08-08 19:34:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krstnmnlsn@chromium.org/451893003/20001
6 years, 4 months ago (2014-08-08 19:35:38 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 19:38:29 UTC) #12
Message was sent while issue was closed.
Change committed as 288417

Powered by Google App Engine
This is Rietveld 408576698