components/password_manager/core/browser/password_form_manager.h - Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Unittest fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/sync_metrics.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index 89c6933f4da207fbd7b76e273b917f8513bc265e..0b69c6ca4b3dd405e16e0ac6b57a15be503d3962 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -219,7 +219,7 @@ class PasswordFormManager : public PasswordStoreConsumer {

// Helper for OnGetPasswordStoreResults to determine whether or not

// the given result form is worth scoring.

- bool IgnoreResult(const autofill::PasswordForm& form) const;

+ bool ShouldIgnoreResult(const autofill::PasswordForm& form) const;

// Helper for Save in the case that best_matches.size() == 0, meaning

// we have no prior record of this form/username/password and the user