chrome/browser/password_manager/sync_metrics.h - Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/sync_metrics.h

Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Unittest fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | chrome/browser/password_manager/sync_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/sync_metrics.h

diff --git a/chrome/browser/password_manager/sync_metrics.h b/chrome/browser/password_manager/sync_metrics.h

index 2a22b07e78e7993f650be9626a8b5c34c0462a17..74daa01414e182da6024f5f26d1be9edcf2e1a03 100644

--- a/chrome/browser/password_manager/sync_metrics.h

+++ b/chrome/browser/password_manager/sync_metrics.h

@@ -12,9 +12,9 @@ class Profile;

namespace password_manager_sync_metrics {

// Returns the sync username for |profile|. Returns an empty string if the

-// |profile| isn't syncing. It would be preferable to only return the username

-// if the user is syncing passwords, but that is not currently possible since

-// this function can be called during sync setup (http://crbug.com/393626).

+// |profile| isn't syncing. This function tries to return an empty string if

+// the user isn't syncing passwords, but it is not always possibly to determine

+// since this code can be called during sync setup (http://crbug.com/393626).

std::string GetSyncUsername(Profile* profile);

// Returns true if |username| and |origin| correspond to the account which is