Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/about_flags.cc

Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Unittest fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index fa08f1d2cd3663591f6bf4c2a6da9cb340c7e496..2a87d8616eb5fe797fca41d61110696bf788da3d 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -503,6 +503,16 @@ const Experiment::Choice kEnableAVFoundationChoices[] = {
};
#endif
+const Experiment::Choice kAutofillSyncCredentialChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
+ { IDS_ALLOW_AUTOFILL_SYNC_CREDENTIAL,
+ password_manager::switches::kAllowAutofillSyncCredential, ""},
+ { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL_FOR_REAUTH,
+ password_manager::switches::kDisallowAutofillSyncCredentialForReauth, ""},
+ { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL,
+ password_manager::switches::kDisallowAutofillSyncCredential, ""},
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1939,6 +1949,13 @@ const Experiment kExperiments[] = {
kOsWin | kOsLinux | kOsCrOS,
SINGLE_VALUE_TYPE(extensions::switches::kEnableExtensionActionRedesign)
},
+ {
+ "autofill-sync-credential",
+ IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_NAME,
+ IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kAutofillSyncCredentialChoices)
+ },
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/password_manager/chrome_password_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698