Chromium Code Reviews| Index: chrome/browser/password_manager/chrome_password_manager_client.h |
| diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h |
| index 203aa420236567ee9de27022a887f25fb8bbf99a..38decf7bdda09ea90603fd8a0027be6d5f5dcd05 100644 |
| --- a/chrome/browser/password_manager/chrome_password_manager_client.h |
| +++ b/chrome/browser/password_manager/chrome_password_manager_client.h |
| @@ -40,8 +40,11 @@ class ChromePasswordManagerClient |
| // PasswordManagerClient implementation. |
| virtual bool IsAutomaticPasswordSavingEnabled() const OVERRIDE; |
| virtual bool IsPasswordManagerEnabledForCurrentPage() const OVERRIDE; |
| + virtual bool ShouldFilterAutofillResult( |
| + const autofill::PasswordForm& form) OVERRIDE; |
| virtual bool IsSyncAccountCredential( |
| const std::string& username, const std::string& origin) const OVERRIDE; |
| + virtual void AutofillResultsComputed() OVERRIDE; |
| virtual void PromptUserToSavePassword( |
| scoped_ptr<password_manager::PasswordFormManager> form_to_save) OVERRIDE; |
| virtual void AutomaticPasswordSave( |
| @@ -90,9 +93,18 @@ class ChromePasswordManagerClient |
| // Returns true if the password manager should be enabled during sync signin. |
| static bool EnabledForSyncSignin(); |
| - private: |
| + protected: |
| + // Callable for tests. |
| ChromePasswordManagerClient(content::WebContents* web_contents, |
| autofill::AutofillClient* autofill_client); |
| + |
| + private: |
| + enum AutofillForSyncCredentialsState { |
| + ALLOW_SYNC_CREDENTIALS, |
| + DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH, |
| + DISALLOW_SYNC_CREDENTIALS, |
| + }; |
| + |
| friend class content::WebContentsUserData<ChromePasswordManagerClient>; |
| // content::WebContentsObserver overrides. |
| @@ -122,6 +134,13 @@ class ChromePasswordManagerClient |
| // |can_use_log_router_|. |
| void NotifyRendererOfLoggingAvailability(); |
| + // Returns true if the last loaded page was for transactional re-auth on a |
| + // Google property. |
| + bool LastLoadWasTransactionalReauthPage() const; |
| + |
| + // Sets |autofill_state_| based on experiment and flag values. |
| + void SetUpAutofillSyncState(); |
| + |
| Profile* const profile_; |
| password_manager::ContentPasswordManagerDriver driver_; |
| @@ -139,6 +158,13 @@ class ChromePasswordManagerClient |
| // True if |this| is registered with some LogRouter which can accept logs. |
| bool can_use_log_router_; |
| + // How to handle the sync credential in ShouldFilterAutofillResult(). |
| + AutofillForSyncCredentialsState autofill_sync_state_; |
| + |
| + // If the sync credential was filtered during autofill. Used for statistics |
| + // reporting. |
| + bool sync_credential_filtered_; |
|
Ilya Sherman
2014/08/14 07:38:14
Optional nit: Perhaps "filtered_" -> "was_filtered
Garrett Casto
2014/08/14 19:48:43
Done.
|
| + |
| DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); |
| }; |