Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/about_flags.cc

Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 39f0c0555de9e79d5357925b328d79839e2ec10a..129e646f0e3c7a39ab384be66af2663e6d5c065d 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -489,6 +489,16 @@ const Experiment::Choice kEnableDropSyncCredentialChoices[] = {
password_manager::switches::kDisableDropSyncCredential, "" },
};
+const Experiment::Choice kAutofillSyncCredentialChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
+ { IDS_ALLOW_AUTOFILL_SYNC_CREDENTIAL,
+ password_manager::switches::kAllowAutofillSyncCredential, ""},
+ { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL_FOR_REAUTH,
+ password_manager::switches::kDisallowAutofillSyncCredentialForReauth, ""},
+ { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL,
+ password_manager::switches::kDisallowAutofillSyncCredential, ""},
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1922,7 +1932,14 @@ const Experiment kExperiments[] = {
IDS_FLAGS_ENABLE_DROP_SYNC_CREDENTIAL_DESCRIPTION,
kOsAll,
MULTI_VALUE_TYPE(kEnableDropSyncCredentialChoices)
- }
+ },
+ {
+ "autofill-sync-credential",
+ IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_NAME,
+ IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kAutofillSyncCredentialChoices)
+ },
};
const Experiment* experiments = kExperiments;

Powered by Google App Engine
This is Rietveld 408576698