Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 451853003: [Password Manager] Setup experiment to restrict autofilling of sync credential (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change cgi params Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 89c6933f4da207fbd7b76e273b917f8513bc265e..de6325a64dcc58d93d88b7ce2736d63b874f727c 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -218,8 +218,11 @@ class PasswordFormManager : public PasswordStoreConsumer {
kSubmitResultMax;
// Helper for OnGetPasswordStoreResults to determine whether or not
- // the given result form is worth scoring.
- bool IgnoreResult(const autofill::PasswordForm& form) const;
+ // the given result form is worth scoring. |autofill_result_filtered| is set
+ // to true iff a result is dropped because the the |client_| requested that
Ilya Sherman 2014/08/12 02:17:33 nit: "the the" -> "the"
Garrett Casto 2014/08/13 20:34:41 Done.
+ // it be filtered (e.g. the form matches the users sync credentials).
Ilya Sherman 2014/08/12 02:17:33 nit: "users" -> "user's"
Garrett Casto 2014/08/13 20:34:41 Done.
+ bool IgnoreResult(const autofill::PasswordForm& form,
Ilya Sherman 2014/08/12 02:17:33 nit: As long as you're here: Might it be clearer t
Garrett Casto 2014/08/13 20:34:41 Done.
+ bool* autofill_result_filtered) const;
// Helper for Save in the case that best_matches.size() == 0, meaning
// we have no prior record of this form/username/password and the user

Powered by Google App Engine
This is Rietveld 408576698