Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 451823002: Implement BlitRect for SkTCompressedAlphaBlitter (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Implement BlitMask for SkTCompressedAlphaBlitter Committed: https://skia.googlesource.com/skia/+/dff491ba3eab17d5ae631e8c46f83a82390213b8

Patch Set 1 #

Patch Set 2 : Update destination block and add comment #

Total comments: 2

Patch Set 3 : Add assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -12 lines) Patch
M src/utils/SkTextureCompressor_Blitter.h View 1 2 2 chunks +72 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
krajcevski
6 years, 4 months ago (2014-08-07 21:36:10 UTC) #1
robertphillips
1gtm but I defer to Mike on this one.
6 years, 4 months ago (2014-08-08 13:34:03 UTC) #2
reed1
https://codereview.chromium.org/451823002/diff/20001/src/utils/SkTextureCompressor_Blitter.h File src/utils/SkTextureCompressor_Blitter.h (right): https://codereview.chromium.org/451823002/diff/20001/src/utils/SkTextureCompressor_Blitter.h#newcode165 src/utils/SkTextureCompressor_Blitter.h:165: virtual void blitMask(const SkMask& mask, const SkIRect& clip) SK_OVERRIDE ...
6 years, 4 months ago (2014-08-08 13:54:52 UTC) #3
robertphillips
https://codereview.chromium.org/451823002/diff/20001/src/utils/SkTextureCompressor_Blitter.h File src/utils/SkTextureCompressor_Blitter.h (right): https://codereview.chromium.org/451823002/diff/20001/src/utils/SkTextureCompressor_Blitter.h#newcode165 src/utils/SkTextureCompressor_Blitter.h:165: virtual void blitMask(const SkMask& mask, const SkIRect& clip) SK_OVERRIDE ...
6 years, 4 months ago (2014-08-08 13:57:20 UTC) #4
krajcevski
Added an assert to make sure blitMask only gets called once.
6 years, 4 months ago (2014-08-08 15:27:56 UTC) #5
robertphillips
lgtm
6 years, 4 months ago (2014-08-08 15:33:44 UTC) #6
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-08 15:33:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/451823002/40001
6 years, 4 months ago (2014-08-08 15:34:18 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 15:41:28 UTC) #9
Message was sent while issue was closed.
Change committed as dff491ba3eab17d5ae631e8c46f83a82390213b8

Powered by Google App Engine
This is Rietveld 408576698