Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: mojo/services/surfaces/surfaces_impl.cc

Issue 451753003: Mojo multiple command buffer support and sample (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better casts Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/surfaces/surfaces_impl.cc
diff --git a/mojo/services/surfaces/surfaces_impl.cc b/mojo/services/surfaces/surfaces_impl.cc
index 5d33d49783eff73fe41d1e7bdff118819c1d9738..7f24a0fb954902b8e4af47c04aa088ce0a0ee01a 100644
--- a/mojo/services/surfaces/surfaces_impl.cc
+++ b/mojo/services/surfaces/surfaces_impl.cc
@@ -44,7 +44,9 @@ void SurfacesImpl::SubmitFrame(SurfaceIdPtr id, FramePtr frame_ptr) {
cc::SurfaceId cc_id = id.To<cc::SurfaceId>();
if (cc::SurfaceIdAllocator::NamespaceForId(cc_id) != id_namespace_) {
// Bad message, do something bad to the caller?
- NOTREACHED();
+ LOG(FATAL) << "Received frame for id " << cc_id.id << " namespace "
+ << cc::SurfaceIdAllocator::NamespaceForId(cc_id)
+ << " should be namespace " << id_namespace_;
return;
}
factory_.SubmitFrame(id.To<cc::SurfaceId>(), mojo::ConvertTo(frame_ptr));
@@ -69,7 +71,9 @@ void SurfacesImpl::CreateGLES2BoundSurface(CommandBufferPtr gles2_client,
cc::SurfaceId cc_id = id.To<cc::SurfaceId>();
if (cc::SurfaceIdAllocator::NamespaceForId(cc_id) != id_namespace_) {
// Bad message, do something bad to the caller?
- NOTREACHED();
+ LOG(FATAL) << "Received request for id " << cc_id.id << " namespace "
+ << cc::SurfaceIdAllocator::NamespaceForId(cc_id)
+ << " should be namespace " << id_namespace_;
return;
}
if (!display_) {
« no previous file with comments | « mojo/services/public/interfaces/native_viewport/native_viewport.mojom ('k') | mojo/services/view_manager/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698