Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 451743002: Pass args to SyncManager::Init via a struct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use scoped_ptr instead of raw pointer. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | sync/internal_api/sync_rollback_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index 148a8ede0609a6c25c3dfd52805f5b99e34d6790..5518d4fa48d01af91ba31470a8907a01d94cf320 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -815,25 +815,21 @@ class SyncManagerTest : public testing::Test,
scoped_refptr<ModelSafeWorker> worker = new FakeModelWorker(GROUP_PASSIVE);
workers.push_back(worker);
- // Takes ownership of |fake_invalidator_|.
- sync_manager_.Init(
- temp_dir_.path(),
- WeakHandle<JsEventHandler>(),
- GURL("https://example.com/"),
- scoped_ptr<HttpPostProviderFactory>(new TestHttpPostProviderFactory()),
- workers,
- extensions_activity_.get(),
- this,
- credentials,
- "fake_invalidator_client_id",
- std::string(),
- std::string(), // bootstrap tokens
- scoped_ptr<InternalComponentsFactory>(GetFactory()).get(),
- &encryptor_,
- scoped_ptr<UnrecoverableErrorHandler>(new TestUnrecoverableErrorHandler)
- .Pass(),
- NULL,
- &cancelation_signal_);
+ SyncManager::InitArgs args;
+ args.database_location = temp_dir_.path();
+ args.service_url = GURL("https://example.com/");
+ args.post_factory =
+ scoped_ptr<HttpPostProviderFactory>(new TestHttpPostProviderFactory());
+ args.workers = workers;
+ args.extensions_activity = extensions_activity_.get(),
+ args.change_delegate = this;
+ args.credentials = credentials;
+ args.invalidator_client_id = "fake_invalidator_client_id";
+ args.internal_components_factory.reset(GetFactory());
+ args.encryptor = &encryptor_;
+ args.unrecoverable_error_handler.reset(new TestUnrecoverableErrorHandler);
+ args.cancelation_signal = &cancelation_signal_;
+ sync_manager_.Init(&args);
sync_manager_.GetEncryptionHandler()->AddObserver(&encryption_observer_);
« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | sync/internal_api/sync_rollback_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698