Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: sync/internal_api/sync_backup_manager_unittest.cc

Issue 451743002: Pass args to SyncManager::Init via a struct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use scoped_ptr instead of raw pointer. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_backup_manager.cc ('k') | sync/internal_api/sync_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_backup_manager_unittest.cc
diff --git a/sync/internal_api/sync_backup_manager_unittest.cc b/sync/internal_api/sync_backup_manager_unittest.cc
index 31b8d872523f48c5257fae04d5cd46608870ae75..e771ea32d847a5d5dffb5a3da31c74c55b7e0aff 100644
--- a/sync/internal_api/sync_backup_manager_unittest.cc
+++ b/sync/internal_api/sync_backup_manager_unittest.cc
@@ -55,27 +55,18 @@ class SyncBackupManagerTest : public syncer::SyncManager::Observer,
.WillOnce(WithArgs<2>(Invoke(this,
&SyncBackupManagerTest::HandleInit)));
- TestInternalComponentsFactory factory(InternalComponentsFactory::Switches(),
- storage_option);
manager->AddObserver(this);
base::RunLoop run_loop;
- manager->Init(temp_dir_.path(),
- MakeWeakHandle(base::WeakPtr<JsEventHandler>()),
- GURL("https://example.com/"),
- scoped_ptr<HttpPostProviderFactory>().Pass(),
- std::vector<scoped_refptr<ModelSafeWorker> >(),
- NULL,
- NULL,
- SyncCredentials(),
- "",
- "",
- "",
- &factory,
- NULL,
- scoped_ptr<UnrecoverableErrorHandler>().Pass(),
- NULL,
- NULL);
+
+ SyncManager::InitArgs args;
+ args.database_location = temp_dir_.path();
+ args.event_handler = MakeWeakHandle(base::WeakPtr<JsEventHandler>());
+ args.service_url = GURL("https://example.com/");
+ args.post_factory = scoped_ptr<HttpPostProviderFactory>().Pass();
+ args.internal_components_factory.reset(new TestInternalComponentsFactory(
+ InternalComponentsFactory::Switches(), storage_option));
+ manager->Init(&args);
loop_.PostTask(FROM_HERE, run_loop.QuitClosure());
run_loop.Run();
}
« no previous file with comments | « sync/internal_api/sync_backup_manager.cc ('k') | sync/internal_api/sync_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698