Issue 451733002: Make Element::elementData() / ensureUniqueElementData() protected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 451733002: Make Element::elementData() / ensureUniqueElementData() protected (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make Element::elementData() / ensureUniqueElementData() protected Make Element::elementData() / ensureUniqueElementData() protected instead of public as ElementData is an Element internal and outside classes should probably not deal with it directly. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179748

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	Source/core/css/resolver/SharedStyleFinder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/html/ClassList.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/451733002/1

6 years, 4 months ago (2014-08-07 17:26:23 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...

6 years, 4 months ago (2014-08-07 18:34:59 UTC) #4

Message was sent while issue was closed.

Change committed as 179748

Expand Messages | Collapse Messages