Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 45173005: Move *Tags / *Attrs arrays from .data to .data.rel.ro section (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move *Tags / *Attrs arrays from .data to .data.rel.ro section Move *Tags / *Attrs arrays from .data to .data.rel.ro section by making the pointers const. This data can now potentially be shared between different instances of the library on Android and thus save RAM. BUG=249746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/build/scripts/templates/MakeQualifiedNames.h.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLIdentifier.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLIdentifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
Proof via objdump: 000000000836cb80 l O .data.rel.ro 0000000000000440 WebCore::HTMLNames::getHTMLTags()::HTMLTags 000000000836d780 l O .data.rel.ro 0000000000000278 WebCore::SVGNames::getSVGTags()::SVGTags ...
7 years, 1 month ago (2013-10-25 21:42:03 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-25 21:48:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/45173005/1
7 years, 1 month ago (2013-10-25 21:48:38 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 23:05:36 UTC) #4
Message was sent while issue was closed.
Change committed as 160635

Powered by Google App Engine
This is Rietveld 408576698