Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 451713002: DevTools: Introduce module initializers (Closed)

Created:
6 years, 4 months ago by apavlov
Modified:
6 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Introduce module initializers For all lazy-loaded modules and workers, _module.js files are introduced, which importScript() all scripts for a particular module. This allows to: - get rid of importScript() calls intertwined with meaningful code, - simplify module loading, since Runtime does not need to read the module descriptor to determine the resource names. This approach is similar to how we implement the CSS loading in inspector.css. R=pfeldman, vsevik BUG=391566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179948

Patch Set 1 #

Patch Set 2 : Rebase and involve worker modules #

Total comments: 2

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -366 lines) Patch
M LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/editor/editor-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/style-formatter.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/script-extract-outline.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/script-formatter.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/BUILD.gn View 1 2 3 chunks +42 lines, -57 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 18 chunks +51 lines, -51 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 11 chunks +17 lines, -0 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 1 2 chunks +11 lines, -3 lines 0 comments Download
M Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +0 lines, -8 lines 0 comments Download
A Source/devtools/front_end/audits/_module.js View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/devtools/front_end/audits/module.json View 1 chunk +10 lines, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsolePanel.js View 1 chunk +0 lines, -3 lines 0 comments Download
A Source/devtools/front_end/console/_module.js View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/console/module.json View 1 chunk +5 lines, -1 line 0 comments Download
A Source/devtools/front_end/devices/_module.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/devices/module.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/documentation/DocumentationView.js View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
A Source/devtools/front_end/documentation/_module.js View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/documentation/module.json View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +0 lines, -9 lines 0 comments Download
A Source/devtools/front_end/elements/_module.js View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/module.json View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionServer.js View 2 chunks +0 lines, -8 lines 0 comments Download
A Source/devtools/front_end/extensions/_module.js View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/devtools/front_end/extensions/module.json View 1 chunk +9 lines, -2 lines 0 comments Download
M Source/devtools/front_end/heap_snapshot_worker/HeapSnapshotWorker.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
A Source/devtools/front_end/heap_snapshot_worker/_module.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/layers/LayersPanel.js View 1 chunk +0 lines, -4 lines 0 comments Download
A Source/devtools/front_end/layers/_module.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/layers/module.json View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
A Source/devtools/front_end/main/_module.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
A Source/devtools/front_end/network/_module.js View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/module.json View 1 chunk +15 lines, -2 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotProxy.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +0 lines, -16 lines 0 comments Download
A Source/devtools/front_end/profiler/_module.js View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/module.json View 1 chunk +17 lines, -1 line 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 1 chunk +0 lines, -10 lines 0 comments Download
A Source/devtools/front_end/resources/_module.js View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/devtools/front_end/resources/module.json View 1 2 1 chunk +13 lines, -2 lines 0 comments Download
M Source/devtools/front_end/script_formatter_worker/JavaScriptFormatter.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/script_formatter_worker/ScriptFormatterWorker.js View 1 2 chunks +2 lines, -13 lines 0 comments Download
A Source/devtools/front_end/script_formatter_worker/_module.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSParser.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
A Source/devtools/front_end/settings/_module.js View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/settings/module.json View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/source_frame/SourceFrame.js View 2 chunks +0 lines, -26 lines 0 comments Download
A Source/devtools/front_end/source_frame/_module.js View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/module.json View 1 1 chunk +27 lines, -1 line 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/ScriptFormatter.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
A Source/devtools/front_end/sources/_module.js View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 1 1 chunk +31 lines, -2 lines 0 comments Download
A Source/devtools/front_end/temp_storage_shared_worker/_module.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
A Source/devtools/front_end/timeline/_module.js View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +28 lines, -1 line 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 6 chunks +17 lines, -30 lines 0 comments Download
M Source/devtools/scripts/concatenate_module_descriptors.py View 3 chunks +16 lines, -4 lines 0 comments Download
M Source/devtools/scripts/inline_js_imports.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
apavlov
6 years, 4 months ago (2014-08-07 15:17:07 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/451713002/diff/40001/Source/devtools/front_end/Runtime.js File Source/devtools/front_end/Runtime.js (right): https://codereview.chromium.org/451713002/diff/40001/Source/devtools/front_end/Runtime.js#newcode446 Source/devtools/front_end/Runtime.js:446: if (this._descriptor.scripts) any case when we don't have ...
6 years, 4 months ago (2014-08-08 12:21:25 UTC) #2
apavlov
https://codereview.chromium.org/451713002/diff/40001/Source/devtools/front_end/Runtime.js File Source/devtools/front_end/Runtime.js (right): https://codereview.chromium.org/451713002/diff/40001/Source/devtools/front_end/Runtime.js#newcode446 Source/devtools/front_end/Runtime.js:446: if (this._descriptor.scripts) On 2014/08/08 12:21:25, lushnikov wrote: > any ...
6 years, 4 months ago (2014-08-08 12:24:02 UTC) #3
eustas
lgtm
6 years, 4 months ago (2014-08-11 12:41:38 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-11 12:44:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/451713002/60001
6 years, 4 months ago (2014-08-11 12:45:27 UTC) #6
commit-bot: I haz the power
Change committed as 179948
6 years, 4 months ago (2014-08-11 13:56:08 UTC) #7
jbroman
A revert of this CL has been created in https://codereview.chromium.org/458753003/ by jbroman@chromium.org. The reason for ...
6 years, 4 months ago (2014-08-11 15:16:28 UTC) #8
apavlov
6 years, 4 months ago (2014-08-14 09:21:29 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698