Issue 451703004: Don't fail unit test if resources not found on device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 451703004: Don't fail unit test if resources not found on device. (Closed)

Created:
6 years, 4 months ago by Tom Hudson

Modified:
6 years, 4 months ago

Reviewers:
djsollen, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Don't fail unit test if resources not found on device. Not 100% sure about the right thing to do here; looks like some other tests warn but don't officially fail. R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/8aed3c151f1b324f65f584646d08f6439ec3eb46

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	tests/FontConfigParser.cpp	View		3 chunks	+27 lines, -9 lines	0 comments	Download

Total messages: 5 (0 generated)

tomhudson

I think you asked for this in the follow-up to https://codereview.chromium.org/439813002/?

6 years, 4 months ago (2014-08-07 15:58:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/451703004/1

6 years, 4 months ago (2014-08-07 17:13:33 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-07 17:21:00 UTC) #5

Message was sent while issue was closed.

Change committed as 8aed3c151f1b324f65f584646d08f6439ec3eb46