Issue 451663003: [SVG2] Harmonize the IDLs of SVGStyleElement and HTMLStyleElement.

Issue 451663003: [SVG2] Harmonize the IDLs of SVGStyleElement and HTMLStyleElement. (Closed)

Created:
6 years, 4 months ago by Erik Dahlström (inactive)

Modified:
6 years, 4 months ago

Reviewers:
pdr., krit

CC:
blink-reviews, krit, arv+blink, fs, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

[SVG2] Harmonize the IDLs of SVGStyleElement and HTMLStyleElement. Add "readonly attribute StyleSheet sheet" to SVGStyleElement's IDL. Spec: https://svgwg.org/svg2-draft/styling.html#InterfaceSVGStyleElement BUG=399271 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179819

Patch Set 2 : fixup test #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	A	LayoutTests/fast/svg/SVGStyleElement.html	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
	M	Source/core/svg/SVGStyleElement.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pdr.

LGTM with a minor test nit. https://codereview.chromium.org/451663003/diff/1/LayoutTests/fast/svg/SVGStyleElement.html File LayoutTests/fast/svg/SVGStyleElement.html (right): https://codereview.chromium.org/451663003/diff/1/LayoutTests/fast/svg/SVGStyleElement.html#newcode7 LayoutTests/fast/svg/SVGStyleElement.html:7: <defs><style>.test { fill: ...

6 years, 4 months ago (2014-08-07 21:47:06 UTC) #2

Erik Dahlström (inactive)

The CQ bit was checked by ed@opera.com

6 years, 4 months ago (2014-08-08 08:05:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/451663003/20001

6 years, 4 months ago (2014-08-08 08:05:48 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-08 10:02:10 UTC) #5

Message was sent while issue was closed.

Change committed as 179819

Expand Messages | Collapse Messages