Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 451633004: Revert of Add a force-layout-height-to-zero layout mode to WebViewImpl (Closed)

Created:
6 years, 4 months ago by jbroman
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Add a force-layout-height-to-zero layout mode to WebViewImpl (https://codereview.chromium.org/382543003/) Reason for revert: Breaks WebKit Android (Nexus4) http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/17772 C 75.423s Main [FAIL] WebFrameTest.SetForceZeroLayoutHeight: C 75.423s Main ../../third_party/WebKit/Source/web/tests/WebFrameTest.cpp:1396: Failure C 75.423s Main Value of: webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height() C 75.423s Main Actual: 735 C 75.423s Main Expected: viewportHeight C 75.423s Main Which is: 480 Original issue's description: > Add a force-layout-height-to-zero layout mode to WebViewImpl > > This makes it possible for the android_webview to implement > 'wrap_content' mode for the view's height without completely ignoring > the viewport meta tag (like it's doing now). > > BUG=392460 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179705 TBR=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jbroman
Created Revert of Add a force-layout-height-to-zero layout mode to WebViewImpl
6 years, 4 months ago (2014-08-07 14:19:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/451633004/1
6 years, 4 months ago (2014-08-07 14:20:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 14:20:23 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-07 14:20:24 UTC) #4
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 4 months ago (2014-08-07 14:21:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/451633004/1
6 years, 4 months ago (2014-08-07 14:22:33 UTC) #6
mkosiba (inactive)
lgtm
6 years, 4 months ago (2014-08-07 14:53:11 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 15:45:57 UTC) #8
Message was sent while issue was closed.
Change committed as 179713

Powered by Google App Engine
This is Rietveld 408576698