Getting rid of net::LOAD_ENABLE_LOAD_TIMING

content/browser/loader/resource_request_info_impl.h

Index: content/browser/loader/resource_request_info_impl.h
diff --git a/content/browser/loader/resource_request_info_impl.h b/content/browser/loader/resource_request_info_impl.h
index 70465f7b10b4338fad6131ba4ba99019ace38a21..54dd85dbaa814e9d6ea3531eb8ff49c2d63d5149 100644
--- a/content/browser/loader/resource_request_info_impl.h
+++ b/content/browser/loader/resource_request_info_impl.h
@@ -56,6 +56,7 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
       bool is_stream,
       bool allow_download,
       bool has_user_gesture,
+      bool enable_load_timing,
       blink::WebReferrerPolicy referrer_policy,
       blink::WebPageVisibilityState visibility_state,
       ResourceContext* context,
@@ -152,6 +153,8 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
   int memory_cost() const { return memory_cost_; }
   void set_memory_cost(int cost) { memory_cost_ = cost; }
 
+  bool is_load_timing_enabled() const { return enable_load_timing_; }
+
  private:
   FRIEND_TEST_ALL_PREFIXES(ResourceDispatcherHostTest,
                            DeletedFilterDetached);
@@ -175,6 +178,7 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
   bool is_stream_;
   bool allow_download_;
   bool has_user_gesture_;
+  bool enable_load_timing_;

[mmenke, 2014/08/07 14:40:55]

Did you do any thinking about whether we even need this field, or can just send
load timing information to the other process unconditionally?  It used to be
that load timing information was collected by monitoring NetLog, so devtool
would have to watch for events and then collect events for each request, and
assemble them to construct load timing information, so there was extra overhead
to gathering the information.

The network stack now gathers that information for all requests, so there's
basically no extra overhead if we always send that information to the renderer.

The two questions here are:
1)  Does this open up any timing attacks / security / privacy issues we care
about.
2)  Does providing that information to request that don't expect it expose any
bugs.

The answer for now may just be "Add a TODO to think about this".

   bool was_ignored_by_handler_;
   ResourceType resource_type_;
   PageTransition transition_type_;