Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 451603002: Fix leaks when the shared worker is requested to be terminated while loading the main script. (Closed)

Created:
6 years, 4 months ago by horo
Modified:
6 years, 4 months ago
CC:
blink-reviews, kouhei (in TOK)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix leaks when the shared worker is requested to be terminated while loading the main script. BUG=398742 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180239

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated sof's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M LayoutTests/LeakExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
horo
jochen@ Could you please review this?
6 years, 4 months ago (2014-08-07 10:58:19 UTC) #1
jochen (gone - plz use gerrit)
On 2014/08/07 10:58:19, horo wrote: > jochen@ > Could you please review this? Is this ...
6 years, 4 months ago (2014-08-07 15:14:39 UTC) #2
horo
On 2014/08/07 15:14:39, jochen (slow - soon OOO) wrote: > On 2014/08/07 10:58:19, horo wrote: ...
6 years, 4 months ago (2014-08-08 00:50:30 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-11 14:33:50 UTC) #4
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-11 23:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/451603002/1
6 years, 4 months ago (2014-08-11 23:26:22 UTC) #6
commit-bot: I haz the power
Change committed as 180013
6 years, 4 months ago (2014-08-12 00:33:15 UTC) #7
sof
https://codereview.chromium.org/451603002/diff/1/Source/web/WebSharedWorkerImpl.cpp File Source/web/WebSharedWorkerImpl.cpp (right): https://codereview.chromium.org/451603002/diff/1/Source/web/WebSharedWorkerImpl.cpp#newcode186 Source/web/WebSharedWorkerImpl.cpp:186: delete this; Shouldn't this return early?
6 years, 4 months ago (2014-08-12 05:02:12 UTC) #8
horo
https://codereview.chromium.org/451603002/diff/1/Source/web/WebSharedWorkerImpl.cpp File Source/web/WebSharedWorkerImpl.cpp (right): https://codereview.chromium.org/451603002/diff/1/Source/web/WebSharedWorkerImpl.cpp#newcode186 Source/web/WebSharedWorkerImpl.cpp:186: delete this; On 2014/08/12 05:02:12, sof wrote: > Shouldn't ...
6 years, 4 months ago (2014-08-12 05:41:45 UTC) #9
horo
A revert of this CL has been created in https://codereview.chromium.org/465863002/ by horo@chromium.org. The reason for ...
6 years, 4 months ago (2014-08-12 05:42:24 UTC) #10
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-14 02:33:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/451603002/80001
6 years, 4 months ago (2014-08-14 02:34:38 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 05:54:16 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (80001) as 180239

Powered by Google App Engine
This is Rietveld 408576698