Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: test/cctest/compiler/test-changes-lowering.cc

Issue 451593002: Remove dangerous default parameter from machine Store operator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/machine-operator.h ('k') | test/cctest/compiler/test-machine-operator-reducer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 6
7 #include "src/compiler/control-builders.h" 7 #include "src/compiler/control-builders.h"
8 #include "src/compiler/generic-node-inl.h" 8 #include "src/compiler/generic-node-inl.h"
9 #include "src/compiler/node-properties-inl.h" 9 #include "src/compiler/node-properties-inl.h"
10 #include "src/compiler/pipeline.h" 10 #include "src/compiler/pipeline.h"
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 } 206 }
207 } 207 }
208 } 208 }
209 209
210 210
211 TEST(RunChangeTaggedToFloat64) { 211 TEST(RunChangeTaggedToFloat64) {
212 ChangesLoweringTester<int32_t> t(kMachineTagged); 212 ChangesLoweringTester<int32_t> t(kMachineTagged);
213 double result; 213 double result;
214 214
215 t.BuildStoreAndLower(t.simplified()->ChangeTaggedToFloat64(), 215 t.BuildStoreAndLower(t.simplified()->ChangeTaggedToFloat64(),
216 t.machine()->Store(kMachineFloat64), &result); 216 t.machine()->Store(kMachineFloat64, kNoWriteBarrier),
217 &result);
217 218
218 if (Pipeline::SupportedTarget()) { 219 if (Pipeline::SupportedTarget()) {
219 FOR_INT32_INPUTS(i) { 220 FOR_INT32_INPUTS(i) {
220 int32_t input = *i; 221 int32_t input = *i;
221 222
222 if (Smi::IsValid(input)) { 223 if (Smi::IsValid(input)) {
223 t.Call(Smi::FromInt(input)); 224 t.Call(Smi::FromInt(input));
224 CHECK_EQ(input, static_cast<int32_t>(result)); 225 CHECK_EQ(input, static_cast<int32_t>(result));
225 } 226 }
226 227
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 388
388 if (TODO_FLOAT64_TO_TAGGED && Pipeline::SupportedTarget()) { 389 if (TODO_FLOAT64_TO_TAGGED && Pipeline::SupportedTarget()) {
389 FOR_FLOAT64_INPUTS(i) { 390 FOR_FLOAT64_INPUTS(i) {
390 input = *i; 391 input = *i;
391 SimulateFullSpace(CcTest::heap()->new_space()); 392 SimulateFullSpace(CcTest::heap()->new_space());
392 Object* result = t.CallWithPotentialGC<Object>(); 393 Object* result = t.CallWithPotentialGC<Object>();
393 t.CheckNumber(input, result); 394 t.CheckNumber(input, result);
394 } 395 }
395 } 396 }
396 } 397 }
OLDNEW
« no previous file with comments | « src/compiler/machine-operator.h ('k') | test/cctest/compiler/test-machine-operator-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698