Issue 451553002: Remove ui/ directory from build/secondary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 451553002: Remove ui/ directory from build/secondary. (Closed)

Created:
6 years, 4 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove ui/ directory from build/secondary. This directory contains a GN build file that defines a dummy "ui" component target that does not really do anything that matters. ui/ targets are almost finished at this time, so there is no point in keeping this ui/ BUILD file in build/secondary. BUG=None TEST=None R=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290188

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	D	build/secondary/ui/BUILD.gn	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/451553002/1

6 years, 4 months ago (2014-08-17 14:49:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290188

Expand Messages | Collapse Messages