Issue 451543002: Android Chromoting: Use explicit intent for opening Feedback screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 451543002: Android Chromoting: Use explicit intent for opening Feedback screen. (Closed)

Created:
6 years, 4 months ago by Lambros

Modified:
6 years, 4 months ago

Reviewers:
jamiewalch, Jamie

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Android Chromoting: Use explicit intent for opening Feedback screen. Using bindService() with implicit intents is unsafe, and will be prohibited in L once the targetSdkVersion gets bumped. Also check that the intent resolves before using it, to avoid crashing the app. BUG=399418 TEST=Pressing the FEEDBACK button shows Feedback screen. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288130