Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 451503003: Add html test case for table not printing properly within nested divs that have certain styles. (Closed)

Created:
6 years, 4 months ago by ivandavid
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add html test case for table not printing properly within nested divs that have certain styles. The table is cut off in print preview and the rest of the webpage ends up being entirely blank. BUG=124517 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288309

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rewrote comments. #

Patch Set 3 : TestExpectations now ordered by bug number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M chrome/test/data/printing/layout_tests/TestExpectations View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
A chrome/test/data/printing/layout_tests/platform/linux/source_html/table/cell-table-expected.png View Binary file 0 comments Download
A chrome/test/data/printing/layout_tests/source_html/table/cell-table.html View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ivandavid
6 years, 4 months ago (2014-08-06 22:59:07 UTC) #1
Lei Zhang
https://codereview.chromium.org/451503003/diff/1/chrome/test/data/printing/layout_tests/TestExpectations File chrome/test/data/printing/layout_tests/TestExpectations (right): https://codereview.chromium.org/451503003/diff/1/chrome/test/data/printing/layout_tests/TestExpectations#newcode9 chrome/test/data/printing/layout_tests/TestExpectations:9: # This tests passes because its consistently wrong grammar: ...
6 years, 4 months ago (2014-08-06 23:12:59 UTC) #2
ivandavid
https://codereview.chromium.org/451503003/diff/1/chrome/test/data/printing/layout_tests/TestExpectations File chrome/test/data/printing/layout_tests/TestExpectations (right): https://codereview.chromium.org/451503003/diff/1/chrome/test/data/printing/layout_tests/TestExpectations#newcode9 chrome/test/data/printing/layout_tests/TestExpectations:9: # This tests passes because its consistently wrong On ...
6 years, 4 months ago (2014-08-06 23:23:54 UTC) #3
ivandavid
On 2014/08/06 23:23:54, ivandavid wrote: > https://codereview.chromium.org/451503003/diff/1/chrome/test/data/printing/layout_tests/TestExpectations > File chrome/test/data/printing/layout_tests/TestExpectations (right): > > https://codereview.chromium.org/451503003/diff/1/chrome/test/data/printing/layout_tests/TestExpectations#newcode9 > ...
6 years, 4 months ago (2014-08-06 23:40:24 UTC) #4
Lei Zhang
lgtm with an optimized png file. Still crunching the png file here...
6 years, 4 months ago (2014-08-06 23:41:43 UTC) #5
ivandavid
The CQ bit was checked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-08 03:54:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/451503003/40001
6 years, 4 months ago (2014-08-08 03:54:47 UTC) #7
ivandavid
The CQ bit was unchecked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-08 03:54:54 UTC) #8
ivandavid
The CQ bit was checked by ivandavid@chromium.org
6 years, 4 months ago (2014-08-08 03:55:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/451503003/40001
6 years, 4 months ago (2014-08-08 03:57:11 UTC) #10
commit-bot: I haz the power
Change committed as 288309
6 years, 4 months ago (2014-08-08 10:28:05 UTC) #11
Lei Zhang
6 years, 4 months ago (2014-08-09 01:45:29 UTC) #12
Message was sent while issue was closed.
... the image is at the wrong DPI.

Powered by Google App Engine
This is Rietveld 408576698