Issue 451503002: Add a GYP dependency from pub_packages onto pkg_files:http_files_stamp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 451503002: Add a GYP dependency from pub_packages onto pkg_files:http_files_stamp. (Closed)

Created:
6 years, 4 months ago by nweiz

Modified:
6 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a GYP dependency from pub_packages onto pkg_files:http_files_stamp. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=39168

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	pkg/pkg.gyp	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/451503002/diff/1/pkg/pkg.gyp File pkg/pkg.gyp (right): https://codereview.chromium.org/451503002/diff/1/pkg/pkg.gyp#newcode45 pkg/pkg.gyp:45: 'pkg_files.gyp:http_files_stamp', Why do you have two gyp files ...

6 years, 4 months ago (2014-08-07 09:55:36 UTC) #2

nweiz

6 years, 4 months ago (2014-08-12 21:52:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39168 (presubmit successful).

Expand Messages | Collapse Messages