Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 451483005: Code generate integration test methods for synchronous request/response pairs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index 8139956df404993dbcd28ea1dd8aa664db212751..7dfd240711385b6b66cd21f4c3420047f05ecbe7 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -13,12 +13,13 @@ import 'package:analysis_server/src/constants.dart';
import 'package:path/path.dart';
import 'package:unittest/unittest.dart';
+import 'integration_test_methods.dart';
import 'protocol_matchers.dart';
/**
* Base class for analysis server integration tests.
*/
-abstract class AbstractAnalysisServerIntegrationTest {
+abstract class AbstractAnalysisServerIntegrationTest extends InttestMixin {
/**
* Amount of time to give the server to respond to a shutdown request before
* forcibly terminating it.
@@ -81,19 +82,7 @@ abstract class AbstractAnalysisServerIntegrationTest {
* analyze [sourceDirectory].
*/
Future standardAnalysisRoot() {
- return server.send(ANALYSIS_SET_ANALYSIS_ROOTS, {
- 'included': [sourceDirectory.path],
- 'excluded': []
- });
- }
-
- /**
- * Send the server a 'server.setSubscriptions' command.
- */
- Future server_setSubscriptions(List<String> subscriptions) {
- return server.send(SERVER_SET_SUBSCRIPTIONS, {
- 'subscriptions': subscriptions
- });
+ return sendAnalysisSetAnalysisRoots([sourceDirectory.path], []);
}
/**
@@ -178,7 +167,7 @@ abstract class AbstractAnalysisServerIntegrationTest {
// Give the server a short time to comply with the shutdown request; if it
// doesn't exit, then forcibly terminate it.
Completer processExited = new Completer();
- server.send(SERVER_SHUTDOWN, null);
+ sendServerShutdown();
return server.exitCode.timeout(SHUTDOWN_TIMEOUT, onTimeout: () {
return server.kill();
});

Powered by Google App Engine
This is Rietveld 408576698