Issue 451483004: Convert fullscreen pixel tests to reftests

Issue 451483004: Convert fullscreen pixel tests to reftests (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
falken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Convert fullscreen pixel tests to reftests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179707

Patch Set 3 : consistency #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -62 lines)			Patch
A +	LayoutTests/fullscreen/full-screen-fixed-pos-parent-expected.html	View		1 chunk	+3 lines, -8 lines	0 comments	Download
D	LayoutTests/fullscreen/full-screen-fixed-pos-parent-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/fullscreen/full-screen-fixed-pos-parent-expected.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	LayoutTests/fullscreen/full-screen-zIndex-expected.html	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
D	LayoutTests/fullscreen/full-screen-zIndex-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/fullscreen/full-screen-zIndex-expected.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	LayoutTests/fullscreen/parent-flow-inline-with-block-child.html	View	1 2	2 chunks	+2 lines, -7 lines	0 comments	Download
A	LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download
D	LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.txt	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	LayoutTests/platform/android/virtual/android/fullscreen/parent-flow-inline-with-block-child-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/platform/linux-x86/virtual/android/fullscreen/parent-flow-inline-with-block-child-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/platform/linux/fullscreen/parent-flow-inline-with-block-child-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/platform/linux/virtual/android/fullscreen/parent-flow-inline-with-block-child-expected.png	View		Binary file		0 comments	Download
D	LayoutTests/platform/linux/virtual/android/fullscreen/parent-flow-inline-with-block-child-expected.txt	View		1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

falken

This is great. lgtm https://codereview.chromium.org/451483004/diff/20001/LayoutTests/fullscreen/parent-flow-inline-with-block-child.html File LayoutTests/fullscreen/parent-flow-inline-with-block-child.html (right): https://codereview.chromium.org/451483004/diff/20001/LayoutTests/fullscreen/parent-flow-inline-with-block-child.html#newcode9 LayoutTests/fullscreen/parent-flow-inline-with-block-child.html:9: if ("webkitRequestFullScreen" in Element.prototype) { ...

6 years, 4 months ago (2014-08-07 03:38:59 UTC) #2

philipj_slow

https://codereview.chromium.org/451483004/diff/20001/LayoutTests/fullscreen/parent-flow-inline-with-block-child.html File LayoutTests/fullscreen/parent-flow-inline-with-block-child.html (right): https://codereview.chromium.org/451483004/diff/20001/LayoutTests/fullscreen/parent-flow-inline-with-block-child.html#newcode9 LayoutTests/fullscreen/parent-flow-inline-with-block-child.html:9: if ("webkitRequestFullScreen" in Element.prototype) { On 2014/08/07 03:38:59, falken ...

6 years, 4 months ago (2014-08-07 07:31:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/451483004/40001

6 years, 4 months ago (2014-08-07 07:33:19 UTC) #6

Message was sent while issue was closed.

Change committed as 179707

Expand Messages | Collapse Messages