Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 451483002: Use standalone widget pages rather than the integrated widget sampler (Closed)

Created:
6 years, 4 months ago by wiltzius
Modified:
6 years, 4 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use standalone widget pages rather than the integrated widget sampler We'll add an integrated page as a further test case next. Also, this fixes the missing URL for core-scroll-header BUG=401203, 394756 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290698

Patch Set 1 #

Patch Set 2 : add WPRs #

Total comments: 2

Patch Set 3 : remove shadow for polymer bug, update wpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M tools/perf/page_sets/data/polymer.json View 1 2 1 chunk +8 lines, -14 lines 0 comments Download
M tools/perf/page_sets/data/polymer_000.wpr.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
D tools/perf/page_sets/data/polymer_002.wpr.sha1 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/polymer_003.wpr.sha1 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/polymer_004.wpr.sha1 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/polymer.py View 1 2 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wiltzius
6 years, 4 months ago (2014-08-06 20:48:46 UTC) #1
Sami
lgtm assuming the answer to my question is yes :) https://codereview.chromium.org/451483002/diff/20001/tools/perf/page_sets/polymer.py File tools/perf/page_sets/polymer.py (right): https://codereview.chromium.org/451483002/diff/20001/tools/perf/page_sets/polymer.py#newcode108 ...
6 years, 4 months ago (2014-08-07 14:51:06 UTC) #2
Sami
Of course I wouldn't be opposed also to cleaning up the logic a little to ...
6 years, 4 months ago (2014-08-07 14:53:50 UTC) #3
tonyg
lgtm https://codereview.chromium.org/451483002/diff/20001/tools/perf/page_sets/polymer.py File tools/perf/page_sets/polymer.py (right): https://codereview.chromium.org/451483002/diff/20001/tools/perf/page_sets/polymer.py#newcode112 tools/perf/page_sets/polymer.py:112: #action_runner.ExecuteJavaScript('window.location.href="about:blank";') Don't we want to completely remove the ...
6 years, 4 months ago (2014-08-09 18:17:32 UTC) #4
wiltzius
The CQ bit was checked by wiltzius@chromium.org
6 years, 4 months ago (2014-08-19 22:29:22 UTC) #5
wiltzius
On 2014/08/09 18:17:32, tonyg wrote: > lgtm > > https://codereview.chromium.org/451483002/diff/20001/tools/perf/page_sets/polymer.py > File tools/perf/page_sets/polymer.py (right): > ...
6 years, 4 months ago (2014-08-19 22:30:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wiltzius@chromium.org/451483002/40001
6 years, 4 months ago (2014-08-19 22:31:28 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 23:42:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290698

Powered by Google App Engine
This is Rietveld 408576698