Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: Source/core/dom/Range.cpp

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take review comment into consideration. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Range.cpp
diff --git a/Source/core/dom/Range.cpp b/Source/core/dom/Range.cpp
index 0b87825708b4dbcb40361fdc0e8c4fc0b6beb687..0a9710b9ea4100a0a83983e68679b391ab0c82da 100644
--- a/Source/core/dom/Range.cpp
+++ b/Source/core/dom/Range.cpp
@@ -462,9 +462,7 @@ bool Range::boundaryPointsValid() const
void Range::deleteContents(ExceptionState& exceptionState)
{
- checkDeleteExtract(exceptionState);
- if (exceptionState.hadException())
- return;
+ ASSERT(boundaryPointsValid());
Yuta Kitamura 2014/08/12 09:07:43 Now that the function name "checkDeleteExtract" do
kangil_ 2014/08/12 10:41:26 Done.
{
EventQueueScope eventQueueScope;

Powered by Google App Engine
This is Rietveld 408576698