Source/core/dom/Range.h - Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.h

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/Range/deleteContents-doctype.html ('K') | « LayoutTests/fast/dom/Range/deleteContents-doctype-expected.txt ('k') | Source/core/dom/Range.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Range.h

diff --git a/Source/core/dom/Range.h b/Source/core/dom/Range.h

index 93a5371d9e108898cbaaa7f0c2769680e14204ce..dd90977053f0b4e117e058ffd326214bdc2b4cac 100644

--- a/Source/core/dom/Range.h

+++ b/Source/core/dom/Range.h

@@ -156,7 +156,7 @@ private:

Node* checkNodeWOffset(Node*, int offset, ExceptionState&) const;

void checkNodeBA(Node*, ExceptionState&) const;

- void checkDeleteExtract(ExceptionState&);

+ void checkExtractPrecondition(ExceptionState&);

enum ActionType { DELETE_CONTENTS, EXTRACT_CONTENTS, CLONE_CONTENTS };

PassRefPtrWillBeRawPtr<DocumentFragment> processContents(ActionType, ExceptionState&);