LayoutTests/fast/dom/Range/deleteContents-doctype.html - Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/deleteContents-doctype.html

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <p>This test verifies if Range.deleteContents can handle doctype.</p>

	3 <script>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6

	7 var range = document.createRange();

	8 range.setStart(document, 0);

	9 range.setEnd(document, 1);

	10

	11 range.deleteContents();

	12 // If Range.deleteContents() throws error, then we will not see below PASS in re sult.
	Yuta Kitamura 2014/08/12 09:07:43 We have "shouldNotThrow()" in js-test.js to test t We have "shouldNotThrow()" in js-test.js to test this specific situation. I recommend using some existing JS testing framework (either js-test or testharness) instead of inventing your own. kangil_ 2014/08/12 10:41:26 Done. Show quoted text On 2014/08/12 09:07:43, Yuta Kitamura wrote: > We have "shouldNotThrow()" in js-test.js to test > this specific situation. > > I recommend using some existing JS testing framework > (either js-test or testharness) instead of inventing > your own. Done.
	13 document.write('PASS');

	14 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/deleteContents-doctype-expected.txt » ('j') | Source/core/dom/Range.cpp » ('J')