LayoutTests/fast/dom/Range/deleteContents-doctype.html - Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/deleteContents-doctype.html

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix typo Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <p>This test verifies if Range.deleteContents can handle doctype.</p>

	3 <script>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6

	7 function generatePassMessage() {
	yosin_UTC9 2014/08/12 03:22:52 nit: We don't need to have separate function for t nit: We don't need to have separate function for this. Please add comment why do we use document.write(). It may not be obvious. kangil_ 2014/08/12 04:16:32 Done. Show quoted text On 2014/08/12 03:22:52, Yosi_UTC9 wrote: > nit: We don't need to have separate function for this. > Please add comment why do we use document.write(). It may not be obvious. Done.
	8 document.write('PASS')

	9 }

	10

	11 var range = document.createRange();

	12 range.setStart(document, 0);

	13 range.setEnd(document, 1);

	14

	15 range.deleteContents();

	16 generatePassMessage();

	17 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/deleteContents-doctype-expected.txt » ('j') | no next file with comments »