LayoutTests/fast/dom/Range/deleteContents-doctype.html - Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype

Side by Side Diff: LayoutTests/fast/dom/Range/deleteContents-doctype.html

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	yosin_UTC9 2014/08/12 01:00:43 For this test, we should have <!DOCTYPE html>. I t For this test, we should have <!DOCTYPE html>. I tried below html, it works but when I added <!DOCTYPE html> at the top, it throws an exception: <div>foobar</div> <script> var range = document.createRange(); range.setStart(document, 0); range.setEnd(document, 1); range.deleteContents(); </script> yosin_UTC9 2014/08/12 01:00:44 nit: We don't need to have html, head, and body ma nit: We don't need to have html, head, and body markup. They are automatically inserted by parser. kangil_ 2014/08/12 01:08:28 I will check and get back to you with result. Show quoted text On 2014/08/12 01:00:43, Yosi_UTC9 wrote: > For this test, we should have <!DOCTYPE html>. > I tried below html, it works but when I added <!DOCTYPE html> at the top, it > throws an exception: > > <div>foobar</div> > <script> > var range = document.createRange(); > range.setStart(document, 0); > range.setEnd(document, 1); > range.deleteContents(); > </script> > I will check and get back to you with result. kangil_ 2014/08/12 02:41:34 Done. Show quoted text On 2014/08/12 01:00:44, Yosi_UTC9 wrote: > nit: We don't need to have html, head, and body markup. They are automatically > inserted by parser. Done. kangil_ 2014/08/12 02:41:34 Done. Show quoted text On 2014/08/12 01:00:43, Yosi_UTC9 wrote: > For this test, we should have <!DOCTYPE html>. > I tried below html, it works but when I added <!DOCTYPE html> at the top, it > throws an exception: > > <div>foobar</div> > <script> > var range = document.createRange(); > range.setStart(document, 0); > range.setEnd(document, 1); > range.deleteContents(); > </script> > Done.
	2 <head>

	3 </head>

	4 <body>

	5 <div id='test'>
	yosin_UTC9 2014/08/12 01:00:43 This test doesn't use these id's and this test doe This test doesn't use these id's and this test doesn't matter what contents in body. Just text node is fine. kangil_ 2014/08/12 02:41:34 Done. Show quoted text On 2014/08/12 01:00:43, Yosi_UTC9 wrote: > This test doesn't use these id's and this test doesn't matter what contents in > body. Just text node is fine. Done.
	6 <p id='start'>start</p>

	7 <p id='end'>end</p>

	8 </div>

	9 <script>

	10 if (window.testRunner)

	11 testRunner.dumpAsText();

	12

	13 function generatePassMessage() {

	14 var html = document.createElement('html');
	yosin_UTC9 2014/08/12 01:00:43 document.write('PASS') is shortest. document.write('PASS') is shortest. kangil_ 2014/08/12 02:41:34 Done. Show quoted text On 2014/08/12 01:00:43, Yosi_UTC9 wrote: > document.write('PASS') is shortest. Done.
	15 var body = document.createElement('body');

	16 body.innerHTML = '<p>PASS</p>';

	17 html.appendChild(body);

	18 document.appendChild(html);

	19 }

	20

	21 var range = document.createRange();

	22 range.setStart(document, 0);

	23 range.setEnd(document, 1);

	24

	25 try {
	yosin_UTC9 2014/08/12 01:00:43 We don't need to have try block. Since, range.dele We don't need to have try block. Since, range.deleteContents() doesn't throw. kangil_ 2014/08/12 02:41:34 Done. Show quoted text On 2014/08/12 01:00:43, Yosi_UTC9 wrote: > We don't need to have try block. Since, range.deleteContents() doesn't throw. Done.
	26 range.deleteContents();

	27 generatePassMessage();

	28 } catch (e) {

	29 }

	30 </script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/deleteContents-doctype-expected.txt » ('j') | no next file with comments »