LayoutTests/fast/dom/Range/deleteContents-doctype.html - Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/deleteContents-doctype.html

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>
	Yuta Kitamura 2014/08/13 03:02:40 super-nit/optional: it is recommended to spell DOC super-nit/optional: it is recommended to spell DOCTYPE in capital letters: <!DOCTYPE html> kangil_ 2014/08/13 04:49:28 Done. Show quoted text On 2014/08/13 03:02:40, Yuta Kitamura wrote: > super-nit/optional: it is recommended to spell DOCTYPE in > capital letters: <!DOCTYPE html> Done.
	2 <script src="../../../resources/js-test.js"></script>

	3 <div id="container">

	4 <p>This test verifies if Range.deleteContents can handle doctype.</p>
	Yuta Kitamura 2014/08/13 03:02:40 With js-test, the test description should be emitt With js-test, the test description should be emitted with description() function. kangil_ 2014/08/13 04:49:28 Done. Show quoted text On 2014/08/13 03:02:40, Yuta Kitamura wrote: > With js-test, the test description should be emitted with > description() function. Done.
	5 </div>

	6 <script>

	7 if (window.testRunner)

	8 testRunner.dumpAsText();
	Yuta Kitamura 2014/08/13 03:02:40 js-test calls dumpAsText() on your behalf, so you js-test calls dumpAsText() on your behalf, so you don't have to do this yourself. kangil_ 2014/08/13 04:49:28 Done. Show quoted text On 2014/08/13 03:02:40, Yuta Kitamura wrote: > js-test calls dumpAsText() on your behalf, so you don't have > to do this yourself. Done.
	9

	10 var range = document.createRange();

	11 range.setStart(document, 0);

	12 range.setEnd(document, 1);

	13

	14 shouldNotThrow("range.deleteContents()");

	15

	16 if (window.testRunner)

	17 document.getElementById('container').outerHTML = '';
	Yuta Kitamura 2014/08/13 03:02:40 Please don't remove the test description; just lea Please don't remove the test description; just leave it and let -expected.txt have it. kangil_ 2014/08/13 04:49:28 Done. Show quoted text On 2014/08/13 03:02:40, Yuta Kitamura wrote: > Please don't remove the test description; just leave it and > let -expected.txt have it. Done.
	18 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/deleteContents-doctype-expected.txt » ('j') | no next file with comments »