LayoutTests/fast/dom/Range/deleteContents-doctype.html - Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/deleteContents-doctype.html

Issue 451403002: Range.deleteContents shouldn't throw HierarchyRequestError on doctype (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 </head>

	4 <body>

	5 <div id='test'>

	6 <p id='start'>start</p>

	7 <p id='end'>end</p>

	8 </div>

	9 <script>

	10 if (window.testRunner)

	11 testRunner.dumpAsText();

	12

	13 var range = document.createRange();

	14 range.setStart(document, 0);

	15 range.setEnd(document, 1);

	16 try {

	17 range.deleteContents();

	18 console.log('Ran as expected!');
	yosin_UTC9 2014/08/11 00:34:24 We can use \|shouldThrow\| in "js-test.js". We can use \|shouldThrow\| in "js-test.js". kangil_ 2014/08/11 00:42:20 Yes, I usually use it. But, in this case, shouldNo Show quoted text On 2014/08/11 00:34:24, Yosi_UTC9 wrote: > We can use \|shouldThrow\| in "js-test.js". Yes, I usually use it. But, in this case, shouldNotThrow("range.deleteContents()"); will cause result like below; CONSOLE ERROR: line 32: Uncaught TypeError: Cannot read property 'firstChild' of null CONSOLE ERROR: line 32: Uncaught TypeError: Cannot read property 'firstChild' of null It is because function getOrCreate in js-test.js can't refer to firstChild due to blown document off. Is it ok to remain console error instead of console.log? yosin_UTC9 2014/08/11 02:16:42 I see. How about using document.write, document.do Show quoted text On 2014/08/11 00:42:20, kangil_ wrote: > On 2014/08/11 00:34:24, Yosi_UTC9 wrote: > > We can use \|shouldThrow\| in "js-test.js". > > Yes, I usually use it. But, in this case, > shouldNotThrow("range.deleteContents()"); will cause result like below; > > CONSOLE ERROR: line 32: Uncaught TypeError: Cannot read property 'firstChild' of > null > CONSOLE ERROR: line 32: Uncaught TypeError: Cannot read property 'firstChild' of > null > > It is because function getOrCreate in js-test.js can't refer to firstChild due > to blown document off. > > Is it ok to remain console error instead of console.log? I see. How about using document.write, document.documentElement.textContent, etc. I think it is better to display result in page rather than console. kangil_ 2014/08/11 04:00:20 Done. Show quoted text On 2014/08/11 02:16:42, Yosi_UTC9 wrote: > On 2014/08/11 00:42:20, kangil_ wrote: > > On 2014/08/11 00:34:24, Yosi_UTC9 wrote: > > > We can use \|shouldThrow\| in "js-test.js". > > > > Yes, I usually use it. But, in this case, > > shouldNotThrow("range.deleteContents()"); will cause result like below; > > > > CONSOLE ERROR: line 32: Uncaught TypeError: Cannot read property 'firstChild' > of > > null > > CONSOLE ERROR: line 32: Uncaught TypeError: Cannot read property 'firstChild' > of > > null > > > > It is because function getOrCreate in js-test.js can't refer to firstChild due > > to blown document off. > > > > Is it ok to remain console error instead of console.log? > > I see. How about using document.write, document.documentElement.textContent, > etc. > > I think it is better to display result in page rather than console. Done.
	19 } catch (e) {

	20 console.log('should not be here..' + e);

	21 }

	22 </script>

	23 </body>

	24 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/deleteContents-doctype-expected.txt » ('j') | no next file with comments »