net/socket/ssl_client_socket_pool_unittest.cc - Issue 451383002: Plumbing for TCP FastOpen for SSL sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 451383002: Plumbing for TCP FastOpen for SSL sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests now working as intended. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_pool_unittest.cc

diff --git a/net/socket/ssl_client_socket_pool_unittest.cc b/net/socket/ssl_client_socket_pool_unittest.cc

index f2792a7dc50b003f1ec785f6a431ec15816fcc7b..64729cc6bd1406ae90701ca6a6a7379be7889a1a 100644

--- a/net/socket/ssl_client_socket_pool_unittest.cc

+++ b/net/socket/ssl_client_socket_pool_unittest.cc

@@ -87,20 +87,24 @@ class SSLClientSocketPoolTest

HttpAuthHandlerFactory::CreateDefault(&host_resolver_)),

session_(CreateNetworkSession()),

direct_transport_socket_params_(

- new TransportSocketParams(HostPortPair("host", 443),

- false,

- OnHostResolutionCallback())),

+ new TransportSocketParams(

+ HostPortPair("host", 443),

+ false,

+ OnHostResolutionCallback(),

+ TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT)),

transport_histograms_("MockTCP"),

transport_socket_pool_(kMaxSockets,

kMaxSocketsPerGroup,

&transport_histograms_,

&socket_factory_),

proxy_transport_socket_params_(

- new TransportSocketParams(HostPortPair("proxy", 443),

- false,

- OnHostResolutionCallback())),

+ new TransportSocketParams(

+ HostPortPair("proxy", 443),

+ false,

+ OnHostResolutionCallback(),

+ TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT)),

socks_socket_params_(

new SOCKSSocketParams(proxy_transport_socket_params_,

true,