Add and start using Checkstyle 5.7

Add and start using Checkstyle 5.7

Start including Checkstyle 5.7 binary to use for Java style presubmit
checks.

BUG=318404
NOTRY=true
R=brettw@chromium.org, yfriedman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289117

[aurimas (slooooooooow), 2014-08-09 18:43:03]

yfriedman: please take a look at this change.

Thanks!
Aurimas

[Yaron, 2014-08-11 17:46:15]

https://codereview.chromium.org/451313002/diff/1/tools/android/checkstyle/che...
File tools/android/checkstyle/checkstyle.py (right):

https://codereview.chromium.org/451313002/diff/1/tools/android/checkstyle/che...
tools/android/checkstyle/checkstyle.py:27: check = subprocess.Popen(['java',
'-cp',
Looks like the internal tree will need an update as well. I assume you have a CL
ready for that?

https://codereview.chromium.org/451313002/diff/1/tools/android/checkstyle/che...
tools/android/checkstyle/checkstyle.py:28:
'third_party/checkstyle/checkstyle-5.7-all.jar',
If this is now checked into the tree, devs don't need to install it anymore.
Please remove from build/install-build-deps-android.sh

[aurimas (slooooooooow), 2014-08-11 22:59:31]

https://codereview.chromium.org/451313002/diff/1/tools/android/checkstyle/che...
File tools/android/checkstyle/checkstyle.py (right):

https://codereview.chromium.org/451313002/diff/1/tools/android/checkstyle/che...
tools/android/checkstyle/checkstyle.py:27: check = subprocess.Popen(['java',
'-cp',
On 2014/08/11 17:46:15, Yaron wrote:
> Looks like the internal tree will need an update as well. I assume you have a
CL
> ready for that?

We use this python script directly so no need for updates.

https://codereview.chromium.org/451313002/diff/1/tools/android/checkstyle/che...
tools/android/checkstyle/checkstyle.py:28:
'third_party/checkstyle/checkstyle-5.7-all.jar',
On 2014/08/11 17:46:15, Yaron wrote:
> If this is now checked into the tree, devs don't need to install it anymore.
> Please remove from build/install-build-deps-android.sh

Done.

[Yaron, 2014-08-11 23:21:38]

lgtm

[aurimas (slooooooooow), 2014-08-11 23:24:33]

brettw@chromium.org for OWNERS review.

[brettw, 2014-08-12 21:12:29]

owners lgtm for adding to third_party

[aurimas (slooooooooow), 2014-08-12 21:17:43]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-08-12 21:26:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/451313002/20001

[commit-bot: I haz the power, 2014-08-12 22:00:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40766)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/45994)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 22:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 22:09:11]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40781)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/46009)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[aurimas (slooooooooow), 2014-08-12 22:48:17]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-08-12 22:54:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/451313002/20001

[commit-bot: I haz the power, 2014-08-12 23:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 23:00:52]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file
third_party/checkstyle/checkstyle-5.7-all.jar.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[aurimas (slooooooooow), 2014-08-12 23:41:06]

Committed patchset #3 manually as 289117 (presubmit successful).