Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 451303003: Oilpan: fix build after r180084. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r180084. Address type conversion subtlety over RawPtr<>s. We have at hand: Handle<Value> toV8(PassRefPtrWillBeRawPtr<NodeList>, ...); template<NodeType>class StaticNodeTypeList : public NodeList { public: static PassRefPtrWillBeRawPtr<StaticNodeTypeList> adopt(..); ... } typedef StaticNodeTypeList<Element> StaticElementList; and the call toV8(StaticElementList::adopt(namedItems), ....); For the toV8() call to be successfully resolved, the adopt() result must be convertible to PassRefPtrWillBeRawPtr<NodeList>. For the non-Oilpan case, we do have the PassRefPtr(const PassRefPtr<U>, EnsurePtrConvertibleArgDecl(U, T)) constructor at hand, which will convert the PassRefPtr<StaticElementList> into PassRefPtr<NodeList>. We do not have the corresponding type-convertible constructor over RawPtr<>, as providing that runs into problems when using RawPtr<> as part of the PassOwnPtrWillBeRawPtr transition type. Address/step-around-the-issue by being explicit about the conversion. TBR=haraken,oilpan-reviews BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-12 19:36:15 UTC) #1
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-12 19:36:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/451303003/1
6 years, 4 months ago (2014-08-12 19:37:36 UTC) #3
commit-bot: I haz the power
Change committed as 180096
6 years, 4 months ago (2014-08-12 19:38:26 UTC) #4
sof
I misdiagnosed the reason why the explicit conversion is needed -- there really is an ...
6 years, 4 months ago (2014-08-12 20:48:23 UTC) #5
haraken
6 years, 4 months ago (2014-08-12 23:29:06 UTC) #6
Message was sent while issue was closed.
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698