Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 451093002: Use test config in SkFontMgr_android. (Closed)

Created:
6 years, 4 months ago by bungeman-skia
Modified:
6 years, 4 months ago
Reviewers:
tomhudson, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Blink layout tests all assume it can provide custom font configuration files on every platform. In moving Android to the font manager, we broke those. They're ugly, but this patch reinstates them. TBR=reed@google.com BUG=chromium:401954 Committed: https://skia.googlesource.com/skia/+/4e3523cf546df4079cf769b8ecc8011403420a45

Patch Set 1 #

Patch Set 2 : Some comments and todos. #

Patch Set 3 : Move logic out to factory. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -8 lines) Patch
M include/ports/SkTypeface_android.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/ports/SkFontConfigInterface_android.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 2 7 chunks +32 lines, -8 lines 1 comment Download

Messages

Total messages: 15 (0 generated)
bungeman-skia
6 years, 4 months ago (2014-08-08 18:24:54 UTC) #1
tomhudson
lgtm Filed http://skbug.com/2817 to track followup.
6 years, 4 months ago (2014-08-08 18:43:55 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-08 18:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/451093002/40001
6 years, 4 months ago (2014-08-08 18:53:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 18:53:39 UTC) #5
commit-bot: I haz the power
Presubmit check for 451093002-40001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-08 18:53:40 UTC) #6
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-08 18:55:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/451093002/40001
6 years, 4 months ago (2014-08-08 18:55:35 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 18:55:40 UTC) #9
commit-bot: I haz the power
Presubmit check for 451093002-40001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-08 18:55:41 UTC) #10
reed1
lgtm
6 years, 4 months ago (2014-08-08 18:56:38 UTC) #11
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-08 18:57:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/451093002/40001
6 years, 4 months ago (2014-08-08 18:57:36 UTC) #13
commit-bot: I haz the power
Change committed as 4e3523cf546df4079cf769b8ecc8011403420a45
6 years, 4 months ago (2014-08-08 19:06:56 UTC) #14
bungeman-skia
6 years, 4 months ago (2014-08-11 17:45:24 UTC) #15
Message was sent while issue was closed. 
See https://codereview.chromium.org/461673002 .

https://codereview.chromium.org/451093002/diff/40001/src/ports/SkFontMgr_andr...
File src/ports/SkFontMgr_android.cpp (right):

https://codereview.chromium.org/451093002/diff/40001/src/ports/SkFontMgr_andr...
src/ports/SkFontMgr_android.cpp:509: SkNEW_ARGS(SkFontMgr_Android,
(mainConfigFile, fallbackConfigFile, basePath));
Need to return here.

Powered by Google App Engine
This is Rietveld 408576698