Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 450993002: Workaround assembly offsets build error for WebRTC standalone. (Closed)

Created:
6 years, 4 months ago by kjellander_chromium
Modified:
6 years, 4 months ago
CC:
chromium-reviews, wwcv, jzern, fgalligan1
Visibility:
Public.

Description

Workaround assembly offsets build error for WebRTC standalone. This enables the new build WebRTC is moving to as a result of the Chromium Git switch in https://webrtc-codereview.appspot.com/16229005/ Without this compilation fails like this (manually linewrapped): [209/2563] ACTION gen_asm_offsets_vp8: unpack_lib_posix_655f0f79285c2909a9158512344a42a2 FAILED: cd ../../chromium/src/third_party/libvpx; ../../../../third_party/libvpx/unpack_lib_posix.sh -d ../../../../out/Release/obj/chromium/src/third_party/libvpx/gen_asm_offsets_vp8.gen -f vp8_asm_enc_offsets.o -a ../../../../out/Release/libvpx_asm_offsets_vp8.a -a ../../../../out/Release/obj/third_party/libvpx/libvpx_asm_offsets_vp8.a -a ../../../../out/Release/obj/Source/WebKit/chromium/third_party/libvpx/libvpx_asm_offsets_vp8.a -a "" Failed to locate a static library. In the current setup, the static library files are put in <(LIB_DIR)/third_party/libvpx but after https://webrtc-codereview.appspot.com/16229005/ they end up in <(LIB_DIR)/chromium/src/third_party/libvpx instead (caused by the fact that we're now symlinking into Chromium's libvpx folder instead). I assume adding another line to fix our problem won't cause any side-effects? BUG=webrtc:2863, chromium:339647 TEST=Passing local build with https://webrtc-codereview.appspot.com/16229005/ and this patch applied. R=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M libvpx.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kjellander_chromium
Frank/Robbie: main review since you have more context. Tom: owner rubberstamp.
6 years, 4 months ago (2014-08-08 11:11:15 UTC) #1
iannucci
On 2014/08/08 11:11:15, kjellander wrote: > Frank/Robbie: main review since you have more context. > ...
6 years, 4 months ago (2014-08-08 15:29:55 UTC) #2
iannucci
On 2014/08/08 15:29:55, iannucci wrote: > On 2014/08/08 11:11:15, kjellander wrote: > > Frank/Robbie: main ...
6 years, 4 months ago (2014-08-08 15:30:20 UTC) #3
Tom Finegan
On 2014/08/08 15:30:20, iannucci wrote: > On 2014/08/08 15:29:55, iannucci wrote: > > On 2014/08/08 ...
6 years, 4 months ago (2014-08-09 02:09:48 UTC) #4
kjellander_chromium
On 2014/08/08 15:30:20, iannucci wrote: > On 2014/08/08 15:29:55, iannucci wrote: > > On 2014/08/08 ...
6 years, 4 months ago (2014-08-11 16:23:38 UTC) #5
kjellander_chromium
6 years, 4 months ago (2014-08-11 16:24:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r288724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698