Issue 450973002: DevTools: animate changes to flame chart window.

Issue 450973002: DevTools: animate changes to flame chart window. (Closed)

Created:
6 years, 4 months ago by pfeldman

Modified:
6 years, 4 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: animate changes to flame chart window. BUG=400987 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179833

Patch Set 1 #

Total comments: 4

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -21 lines)			Patch
M	Source/devtools/front_end/components/FlameChart.js	View	5 chunks	+41 lines, -18 lines	2 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	1 chunk	+5 lines, -1 line	2 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameOverview.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineOverviewPane.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/ui/UIUtils.js	View	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/450973002/diff/1/Source/devtools/front_end/components/FlameChart.js File Source/devtools/front_end/components/FlameChart.js (right): https://codereview.chromium.org/450973002/diff/1/Source/devtools/front_end/components/FlameChart.js#newcode452 Source/devtools/front_end/components/FlameChart.js:452: delete this._cancelWindowTimesAnimation; this._cancelWindowTimesAnimation = null; https://codereview.chromium.org/450973002/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js ...

6 years, 4 months ago (2014-08-08 12:40:43 UTC) #2

pfeldman

https://codereview.chromium.org/450973002/diff/1/Source/devtools/front_end/components/FlameChart.js File Source/devtools/front_end/components/FlameChart.js (right): https://codereview.chromium.org/450973002/diff/1/Source/devtools/front_end/components/FlameChart.js#newcode452 Source/devtools/front_end/components/FlameChart.js:452: delete this._cancelWindowTimesAnimation; I think we delete all the flags ...

6 years, 4 months ago (2014-08-08 12:43:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/450973002/1

6 years, 4 months ago (2014-08-08 12:44:06 UTC) #5

Message was sent while issue was closed.

Change committed as 179833

Expand Messages | Collapse Messages