Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 450943002: Video Player: Show favicon as task icon on Files.app (Closed)

Created:
6 years, 4 months ago by yoshiki
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Video Player: Show favicon as task icon on Files.app BUG=401399 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289932

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/file_manager/file_manager_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/video_player/manifest.json View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 4 months ago (2014-08-08 08:13:18 UTC) #1
hirono
https://codereview.chromium.org/450943002/diff/1/ui/file_manager/video_player/manifest.json File ui/file_manager/video_player/manifest.json (right): https://codereview.chromium.org/450943002/diff/1/ui/file_manager/video_player/manifest.json#newcode12 ui/file_manager/video_player/manifest.json:12: "32": "images/icon/video-player-32.png", I'm not sure but this may be ...
6 years, 4 months ago (2014-08-08 08:54:20 UTC) #2
yoshiki
@hirono, PTAL https://codereview.chromium.org/450943002/diff/1/ui/file_manager/video_player/manifest.json File ui/file_manager/video_player/manifest.json (right): https://codereview.chromium.org/450943002/diff/1/ui/file_manager/video_player/manifest.json#newcode12 ui/file_manager/video_player/manifest.json:12: "32": "images/icon/video-player-32.png", On 2014/08/08 08:54:20, hirono wrote: ...
6 years, 4 months ago (2014-08-15 08:15:26 UTC) #3
hirono
On 2014/08/15 08:15:26, yoshiki wrote: > @hirono, PTAL > > https://codereview.chromium.org/450943002/diff/1/ui/file_manager/video_player/manifest.json > File ui/file_manager/video_player/manifest.json (right): ...
6 years, 4 months ago (2014-08-15 08:40:15 UTC) #4
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-15 09:14:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/450943002/1
6 years, 4 months ago (2014-08-15 09:16:28 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 17:58:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289932

Powered by Google App Engine
This is Rietveld 408576698