Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/chromium/dart_buildbot_run.py

Issue 450923002: Use exitcode of running the annotated steps script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/chromium/dart_buildbot_run.py
===================================================================
--- scripts/slave/chromium/dart_buildbot_run.py (revision 288041)
+++ scripts/slave/chromium/dart_buildbot_run.py (working copy)
@@ -22,8 +22,11 @@
script = 'src/dart/tools/dartium/buildbot_annotated_steps.py'
else:
script = 'src/dartium_tools/buildbot_annotated_steps.py'
- chromium_utils.RunCommand([sys.executable, script])
+ result = chromium_utils.RunCommand([sys.executable, script])
+ if result:
+ print 'Running annotated steps % failed' % script
+ return 1
# BIG HACK
# Normal ninja clobbering does not work due to symlinks/python on windows
# Full clobbering before building does not work since it will destroy
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698