Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 450903002: Random clean up around Chrome OS file manager code. (Closed)

Created:
6 years, 4 months ago by kinaba
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, yoshiki+watch_chromium.org, nhiroki, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Random clean up around Chrome OS file manager code. Mostly fixing typos and missing/redundant #includes. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -55 lines) Patch
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/drive_test_util.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_transform.js View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_util.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/viewport.js View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/video_player/js/cast/cast_extension_discoverer.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/cast/cast_video_element.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/video_player/js/cast/caster.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/cast/media_manager.js View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/file_manager/video_player/js/error_util.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
6 years, 4 months ago (2014-08-08 05:39:06 UTC) #1
hirono
lgtm!
6 years, 4 months ago (2014-08-08 05:49:24 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 4 months ago (2014-08-08 05:58:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/450903002/1
6 years, 4 months ago (2014-08-08 06:01:26 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:29:32 UTC) #5
Message was sent while issue was closed. 
Change committed as 288310

Powered by Google App Engine
This is Rietveld 408576698