Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: content/public/browser/ssl_host_state_delegate.h

Issue 450833002: Add additional UMA stats for remembering certificate decisions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes from felt comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/ssl_host_state_delegate.h
diff --git a/content/public/browser/ssl_host_state_delegate.h b/content/public/browser/ssl_host_state_delegate.h
index 859a4e78be5fce2548dc41fa09af757927fbc55d..2b3f990b589c26188f58dfe03261f94b4c5d38f4 100644
--- a/content/public/browser/ssl_host_state_delegate.h
+++ b/content/public/browser/ssl_host_state_delegate.h
@@ -32,9 +32,11 @@ class SSLHostStateDelegate {
virtual void Clear() = 0;
// Queries whether |cert| is allowed or denied for |host| and |error|.
- virtual net::CertPolicy::Judgment QueryPolicy(const std::string& host,
- net::X509Certificate* cert,
- net::CertStatus error) = 0;
+ virtual net::CertPolicy::Judgment QueryPolicy(
+ const std::string& host,
+ net::X509Certificate* cert,
+ net::CertStatus error,
+ bool* expired_previous_decision) = 0;
felt 2014/08/08 17:55:33 why a bool* in some places and a bool in others?
jww 2014/08/12 04:51:02 The pointer ones are because they are return value
felt 2014/08/12 04:54:33 Oh, no, you don't need to. I see now.
// Revoke all allow/deny preferences for |host|.
virtual void RevokeAllowAndDenyPreferences(const std::string& host) = 0;

Powered by Google App Engine
This is Rietveld 408576698