Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 450833002: Add additional UMA stats for remembering certificate decisions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update content_browser_client subclasses Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index 009fdf9651e886654824aaca6152196c0398a9f1..8b30e032ec40e7d119341f252b6c18dd897e8eae 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -56,14 +56,14 @@ class SSLBlockingPage : public content::InterstitialPageDelegate,
// Creates an SSL blocking page. If the blocking page isn't shown, the caller
// is responsible for cleaning up the blocking page, otherwise the
// interstitial takes ownership when shown.
- SSLBlockingPage(
- content::WebContents* web_contents,
- int cert_error,
- const net::SSLInfo& ssl_info,
- const GURL& request_url,
- bool overridable,
- bool strict_enforcement,
- const base::Callback<void(bool)>& callback);
+ SSLBlockingPage(content::WebContents* web_contents,
+ int cert_error,
+ const net::SSLInfo& ssl_info,
+ const GURL& request_url,
+ bool overridable,
+ bool strict_enforcement,
+ bool expired_but_previously_allowed,
+ const base::Callback<void(bool)>& callback);
// A method that sets strings in the specified dictionary from the passed
// vector so that they can be used to resource the ssl_roadblock.html/
@@ -120,6 +120,9 @@ class SSLBlockingPage : public content::InterstitialPageDelegate,
bool captive_portal_no_response_;
// Was a captive portal detected?
bool captive_portal_detected_;
+ // Did the user previously allow a bad certificate but the decision has now
+ // expried?
felt 2014/08/08 00:17:06 expired
jww 2014/08/08 15:55:45 Done.
+ bool expired_but_previously_allowed_;
content::NotificationRegistrar registrar_;

Powered by Google App Engine
This is Rietveld 408576698