Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5307)

Unified Diff: chrome/browser/ssl/chrome_ssl_host_state_delegate.h

Issue 450833002: Add additional UMA stats for remembering certificate decisions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on ToT Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_ssl_host_state_delegate.h
diff --git a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
index 05d194e7c358c29bb0a7865944d392a8eaac3534..1353c20020a5b958d91d33779bd037cc6e25f1bc 100644
--- a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
+++ b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
@@ -35,9 +35,11 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
net::X509Certificate* cert,
net::CertStatus error) OVERRIDE;
virtual void Clear() OVERRIDE;
- virtual net::CertPolicy::Judgment QueryPolicy(const std::string& host,
- net::X509Certificate* cert,
- net::CertStatus error) OVERRIDE;
+ virtual net::CertPolicy::Judgment QueryPolicy(
+ const std::string& host,
+ net::X509Certificate* cert,
+ net::CertStatus error,
+ bool* expired_previous_decision) OVERRIDE;
virtual void HostRanInsecureContent(const std::string& host,
int pid) OVERRIDE;
virtual bool DidHostRunInsecureContent(const std::string& host,
@@ -66,6 +68,8 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
FRIEND_TEST_ALL_PREFIXES(ForgetInstantlySSLHostStateDelegateTest,
MakeAndForgetException);
FRIEND_TEST_ALL_PREFIXES(RememberSSLHostStateDelegateTest, AfterRestart);
+ FRIEND_TEST_ALL_PREFIXES(RememberSSLHostStateDelegateTest,
+ QueryPolicyExpired);
// Used to specify whether new content setting entries should be created if
// they don't already exist when querying the user's settings.
@@ -105,9 +109,13 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
// GetValidCertDecisionsDict will create a new set of entries within the
// dictionary if they do not already exist. Otherwise will fail and return if
// NULL if they do not exist.
+ //
+ // |expired_previous_decision| is set to true if there had been a previous
+ // decision made by the user but it has expired. Otherwise it is set to false.
base::DictionaryValue* GetValidCertDecisionsDict(
base::DictionaryValue* dict,
- CreateDictionaryEntriesDisposition create_entries);
+ CreateDictionaryEntriesDisposition create_entries,
+ bool* expired_previous_decision);
scoped_ptr<base::Clock> clock_;
RememberSSLExceptionDecisionsDisposition should_remember_ssl_decisions_;
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698