Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 450813002: Add some performance testing for paint invalidations (Closed)

Created:
6 years, 4 months ago by Julien - ping for review
Modified:
6 years, 4 months ago
CC:
blink-reviews, esprehn, tonyg
Project:
blink
Visibility:
Public.

Description

Add some performance testing for paint invalidations After moving paint invalidations after compositing updates, we lost most of the performance coverage we had as most performance tests trigger layout without generating a frame. The new cases are DRT specific as we use Internals.forceCompositingUpdate. This is required as rAF will cap the tests to the sync frequency. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179881

Patch Set 1 #

Patch Set 2 : Better tests. #

Total comments: 4

Patch Set 3 : Fixed Elliott's review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -0 lines) Patch
A PerformanceTests/PaintInvalidation/grow-shrink-rectangle-invalidate-overlapping.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
A PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A PerformanceTests/PaintInvalidation/shift-rectangle-translateX-invalidate.html View 1 2 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Julien - ping for review
6 years, 4 months ago (2014-08-07 23:42:33 UTC) #1
esprehn
lgtm with the tests fixed. https://codereview.chromium.org/450813002/diff/20001/PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html File PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html (right): https://codereview.chromium.org/450813002/diff/20001/PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html#newcode13 PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html:13: .translated { Translate usually ...
6 years, 4 months ago (2014-08-08 03:13:54 UTC) #2
Julien - ping for review
Thanks Elliott! https://codereview.chromium.org/450813002/diff/20001/PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html File PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html (right): https://codereview.chromium.org/450813002/diff/20001/PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html#newcode13 PerformanceTests/PaintInvalidation/shift-rectangle-left-invalidate.html:13: .translated { On 2014/08/08 03:13:54, esprehn wrote: ...
6 years, 4 months ago (2014-08-09 00:35:16 UTC) #3
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 4 months ago (2014-08-09 00:35:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/450813002/40001
6 years, 4 months ago (2014-08-09 00:36:26 UTC) #5
commit-bot: I haz the power
Change committed as 179881
6 years, 4 months ago (2014-08-09 01:46:47 UTC) #6
tonyg
6 years, 4 months ago (2014-08-09 17:28:49 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/459663002/ by tonyg@chromium.org.

The reason for reverting is: Timing out on perf bots. One example:
http://chromegw/i/chromium.perf/builders/Linux%20Perf%20%281%29/builds/2268/s....

Powered by Google App Engine
This is Rietveld 408576698