Use font manager on Android.

Use font manager on Android.

The corresponding Blink side change is https://codereview.chromium.org/447233003/ . These two can be committed in any order.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288168

[bungeman-skia, 2014-08-07 17:51:20]

lgtm

[bungeman-skia, 2014-08-07 17:51:27]

The CQ bit was checked by bungeman@google.com

[djsollen, 2014-08-07 17:52:44]

lgtm, but I'm not an committer so it doesn't count for much.

[tomhudson, 2014-08-07 17:54:50]

lgtm

[commit-bot: I haz the power, 2014-08-07 17:56:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bungeman@chromium.org/450733002/20001

[commit-bot: I haz the power, 2014-08-07 19:39:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-07 20:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-07 20:11:34]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bungeman-skia, 2014-08-07 20:13:53]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-08-07 20:18:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bungeman@chromium.org/450733002/20001

[commit-bot: I haz the power, 2014-08-07 23:44:02]

Change committed as 288168

[Michael van Ouwerkerk, 2014-08-08 10:36:03]

Is it possible these changes are related? Looks like font size changed a little:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLarge...

[tomhudson, 2014-08-08 12:20:49]

On 2014/08/08 10:36:03, Michael van Ouwerkerk wrote:
> Is it possible these changes are related? Looks like font size changed a
little:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLarge...

This should have been an Android-only text change, and most of those changes are
not text-related or not Android-only.
It's *possible* it changed some font lookup behavior on Android; it'd be good
for Ben to look at fast/text/chromium-linux-fontconfig-renderstyle.html, but
even there are are some small non-Android font changes going on.

[bungeman-skia, 2014-08-08 14:15:18]

On 2014/08/08 12:20:49, tomhudson wrote:
> On 2014/08/08 10:36:03, Michael van Ouwerkerk wrote:
> > Is it possible these changes are related? Looks like font size changed a
> little:
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLarge...
> 
> This should have been an Android-only text change, and most of those changes
are
> not text-related or not Android-only.
> It's *possible* it changed some font lookup behavior on Android; it'd be good
> for Ben to look at fast/text/chromium-linux-fontconfig-renderstyle.html, but
> even there are are some small non-Android font changes going on.

Things are difficult because there is no trybot for the android layout bot. I
will need to see how Ahem is being used, as that might be related. The rest of
the changes I see in your link look like someone mucked with the linear metrics
and subpixel rendering selection.

[bungeman-skia, 2014-08-12 18:02:40]

On 2014/08/08 14:15:18, bungeman1 wrote:
> On 2014/08/08 12:20:49, tomhudson wrote:
> > On 2014/08/08 10:36:03, Michael van Ouwerkerk wrote:
> > > Is it possible these changes are related? Looks like font size changed a
> > little:
> > >
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLarge...
> > 
> > This should have been an Android-only text change, and most of those changes
> are
> > not text-related or not Android-only.
> > It's *possible* it changed some font lookup behavior on Android; it'd be
good
> > for Ben to look at fast/text/chromium-linux-fontconfig-renderstyle.html, but
> > even there are are some small non-Android font changes going on.
> 
> Things are difficult because there is no trybot for the android layout bot. I
> will need to see how Ahem is being used, as that might be related. The rest of
> the changes I see in your link look like someone mucked with the linear
metrics
> and subpixel rendering selection.

This change required follow on CLs https://codereview.chromium.org/451093002/
and https://codereview.chromium.org/461673002/ . Skia provides some test globals
which Blink can set in order to use a set of test fonts. This change did not
allow for this, and it was added in the follow on CLs. After all of these
changes rolled into Chromium, the issue was resolved. We have also commented on
our wish to eventually remove these globals and provide a better means of having
alternate fonts so that this will not happen again (and the code will also be
much cleaner).