Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: tools/dom/scripts/dartdomgenerator.py

Issue 450693005: Eliminate the old non blink code paths from idl generation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/dom/scripts/go.sh » ('j') | tools/dom/scripts/htmldartgenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/dartdomgenerator.py
diff --git a/tools/dom/scripts/dartdomgenerator.py b/tools/dom/scripts/dartdomgenerator.py
index d9e1837695ceac8cd4e742c83f8b940d00b439e0..9904565b3837299e29851d0adc4d5e71b2f9d7dd 100755
--- a/tools/dom/scripts/dartdomgenerator.py
+++ b/tools/dom/scripts/dartdomgenerator.py
@@ -50,8 +50,7 @@ def LoadDatabase(database_dir, use_database_cache):
return common_database
def GenerateFromDatabase(common_database, dart2js_output_dir,
- dartium_output_dir, update_dom_metadata=False,
- dart_use_blink=False):
+ dartium_output_dir, update_dom_metadata=False):
current_dir = os.path.dirname(__file__)
auxiliary_dir = os.path.join(current_dir, '..', 'src')
template_dir = os.path.join(current_dir, '..', 'templates')
@@ -121,7 +120,7 @@ def GenerateFromDatabase(common_database, dart2js_output_dir,
template_loader = TemplateLoader(template_dir,
template_paths,
{'DARTIUM': True, 'DART2JS': False,
- 'DART_USE_BLINK' : dart_use_blink})
Emily Fortuna 2014/08/07 18:35:11 shall we just delete this key from the map?
Leaf 2014/08/07 19:38:24 Done.
+ 'DART_USE_BLINK' : True})
backend_options = GeneratorOptions(
template_loader, webkit_database, type_registry, renamer,
metadata)
@@ -134,7 +133,7 @@ def GenerateFromDatabase(common_database, dart2js_output_dir,
auxiliary_dir)
backend_factory = lambda interface:\
DartiumBackend(interface, native_library_emitter,
- cpp_library_emitter, backend_options, dart_use_blink)
+ cpp_library_emitter, backend_options)
dart_libraries = DartLibraries(
HTML_LIBRARY_NAMES, template_loader, 'dartium', dartium_output_dir)
RunGenerator(dart_libraries, dart_output_dir,
@@ -179,10 +178,6 @@ def main():
action='store', type='string',
default=None,
help='Directory to put the generated files')
- parser.add_option('--use-blink', dest='dart_use_blink',
- action='store_true',
- default=False,
- help='''Delegate all native calls to dart:blink''')
parser.add_option('--use-database-cache', dest='use_database_cache',
action='store_true',
default=False,
@@ -217,7 +212,7 @@ def main():
# Load the previously generated database.
database = LoadDatabase(database_dir, options.use_database_cache)
GenerateFromDatabase(database, dart2js_output_dir, dartium_output_dir,
- options.update_dom_metadata, options.dart_use_blink)
+ options.update_dom_metadata)
if 'htmldart2js' in systems:
_logger.info('Generating dart2js single files.')
« no previous file with comments | « no previous file | tools/dom/scripts/go.sh » ('j') | tools/dom/scripts/htmldartgenerator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698