Add ManagePasswordsBubbleNeverSaveViewController and unit tests.

Add ManagePasswordsBubbleNeverSaveViewController and unit tests.

BUG=328847
Committed: https://crrev.com/a07419281ba5b9ce15059a2b64b75a57fa64fbae
Cr-Commit-Position: refs/heads/master@{#291902}

[dconnelly, 2014-08-07 17:10:10]

There's only one more after this :/

[Scott Hess - ex-Googler, 2014-08-22 21:45:36]

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm
(right):

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:29:
- (void)onConfirmClicked {
-(void)actionName:(id)sender;

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:34:
- (void)onUndoClicked {
here too.

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:77:
2 * password_manager::mac::ui::kFramePadding;
using namespace password_manager::mac::ui;

https://codereview.chromium.org/450643003/diff/80001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/450643003/diff/80001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:1635:
'browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm',
This isn't in the CL.

[dconnelly, 2014-08-25 11:44:21]

Again, sorry for the churn here.

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm
(right):

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:29:
- (void)onConfirmClicked {
On 2014/08/22 21:45:35, Scott Hess wrote:
> -(void)actionName:(id)sender;

Done.

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:34:
- (void)onUndoClicked {
On 2014/08/22 21:45:35, Scott Hess wrote:
> here too.

Done.

https://codereview.chromium.org/450643003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:77:
2 * password_manager::mac::ui::kFramePadding;
On 2014/08/22 21:45:35, Scott Hess wrote:
> using namespace password_manager::mac::ui;

Done.

https://codereview.chromium.org/450643003/diff/80001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/450643003/diff/80001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:1635:
'browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm',
On 2014/08/22 21:45:35, Scott Hess wrote:
> This isn't in the CL.

Fixed.

[Scott Hess - ex-Googler, 2014-08-25 22:18:17]

LGTM with minor changes requested.

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm
(right):

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:79:
std::max(NSWidth(titleLabel.frame), minContentWidth);
Consistency on use of [x frame] versus x.frame.

But I'll say I'm mixed on the next line saying x.frame.size.  IMHO that case
just reads clearer than [x frame].size .

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:107:
curY = NSMaxY(confirmationLabel.frame) + kUnrelatedControlVerticalPadding;
And another.

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm
(right):

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm:78:
[undoButton.target performSelector:undoButton.action];
-performClick:  :-).

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm:85:
[confirmButton.target performSelector:confirmButton.action];
Also here.

[dconnelly, 2014-08-26 08:51:04]

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm
(right):

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:79:
std::max(NSWidth(titleLabel.frame), minContentWidth);
On 2014/08/25 22:18:16, Scott Hess wrote:
> Consistency on use of [x frame] versus x.frame.
> 
> But I'll say I'm mixed on the next line saying x.frame.size.  IMHO that case
> just reads clearer than [x frame].size .

Done.

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller.mm:107:
curY = NSMaxY(confirmationLabel.frame) + kUnrelatedControlVerticalPadding;
On 2014/08/25 22:18:16, Scott Hess wrote:
> And another.

Done.

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm
(right):

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm:78:
[undoButton.target performSelector:undoButton.action];
On 2014/08/25 22:18:16, Scott Hess wrote:
> -performClick:  :-).

Done. :|

https://codereview.chromium.org/450643003/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm:85:
[confirmButton.target performSelector:confirmButton.action];
On 2014/08/25 22:18:16, Scott Hess wrote:
> Also here.

Done.

[dconnelly, 2014-08-26 09:04:27]

Patchset #7 (id:140001) has been deleted

[dconnelly, 2014-08-26 12:25:09]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-26 12:26:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/450643003/120001

[commit-bot: I haz the power, 2014-08-26 13:33:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-26 14:12:55]

Committed patchset #6 (120001) as 1f009b7c5d71bf799b27907a024480a84cae6968

[commit-bot: I haz the power, 2014-09-10 02:42:48]

Patchset 6 (id:??) landed as
https://crrev.com/a07419281ba5b9ce15059a2b64b75a57fa64fbae
Cr-Commit-Position: refs/heads/master@{#291902}